From 30f40aee2ecb1a4d0de83a0c1a8adac983273e80 Mon Sep 17 00:00:00 2001 From: onyx-and-iris Date: Fri, 9 Jan 2026 11:54:55 +0000 Subject: [PATCH] make Type arg optional, if not passed print current stream service settings. this is a bugfix. --- README.md | 22 ++++++++++++---------- settings.go | 6 +++--- 2 files changed, 15 insertions(+), 13 deletions(-) diff --git a/README.md b/README.md index 85be2b2..4dae258 100644 --- a/README.md +++ b/README.md @@ -749,26 +749,28 @@ gobs-cli settings profile SimpleOutput VBitrate 6000 ``` - stream-service: Get/Set stream service setting. - - args: Type - flags: - --key: Stream key. - --server: Stream server URL. + *optional* + - args: Type + ```console gobs-cli settings stream-service -gobs-cli settings stream-service rtmp_common --key='live_xyzxyzxyzxyz' +gobs-cli settings stream-service --key='live_xyzxyzxyzxyz' rtmp_common ``` - video: Get/Set video setting. -- flags: - - --show: Show video settings. - - --base-width: Base (canvas) width. - - --base-height: Base (canvas) height. - - --output-width: Output (scaled) width. - - --output-height: Output (scaled) height. - - --fps-num: Frames per second numerator. - - --fps-den: Frames per second denominator. + - flags: + - --show: Show video settings. + - --base-width: Base (canvas) width. + - --base-height: Base (canvas) height. + - --output-width: Output (scaled) width. + - --output-height: Output (scaled) height. + - --fps-num: Frames per second numerator. + - --fps-den: Frames per second denominator. ```console gobs-cli settings video --show diff --git a/settings.go b/settings.go index 1586301..1be75b0 100644 --- a/settings.go +++ b/settings.go @@ -189,7 +189,7 @@ func (cmd *SettingsProfileCmd) Run(ctx *context) error { // SettingsStreamServiceCmd gets/ sets stream service settings. type SettingsStreamServiceCmd struct { - Type string `arg:"" help:"Stream type (e.g., rtmp_common, rtmp_custom)." required:""` + Type string `arg:"" help:"Stream type (e.g., rtmp_common, rtmp_custom)." optional:""` Key string ` help:"Stream key." flag:""` Server string ` help:"Stream server URL." flag:""` } @@ -202,7 +202,7 @@ func (cmd *SettingsStreamServiceCmd) Run(ctx *context) error { return fmt.Errorf("failed to get stream service settings: %w", err) } - if cmd.Key == "" && cmd.Server == "" { + if cmd.Type == "" { t := table.New().Border(lipgloss.RoundedBorder()). BorderStyle(lipgloss.NewStyle().Foreground(ctx.Style.border)). Headers("Stream Service Setting", "Value"). @@ -219,7 +219,7 @@ func (cmd *SettingsStreamServiceCmd) Run(ctx *context) error { return style }) - t.Row("Type", cmd.Type) + t.Row("Type", resp.StreamServiceType) t.Row("Key", resp.StreamServiceSettings.Key) t.Row("Server", resp.StreamServiceSettings.Server)