README.md

@@ -67,9 +67,7 @@ For a full list of requests refer to [Requests](https://github.com/obsproject/ob
 
 ### Events
 
-Register blocks with the Event client using the `on` method. Event tokens should match the event name but snake cased.
+Register `on_` callback methods. Method names should match the api event but snake cased.
-
-The event data will be passed to the block.
 
 example:
 
@@ -77,14 +75,23 @@ example:
 class Observer
     def initialize
         @e_client = OBSWS::Events::Client.new(host: "localhost", port: 4455, password: "strongpassword")
-        # register blocks on event types.
+        # register callback methods with the Event client
-        @e_client.on :current_program_scene_changed do |data|
+        @e_client.register(
+          [
+            method(:on_current_program_scene_changed),
+            method(:on_input_mute_state_changed)
+          ]
+        )
+    end
+
+    # define "on_" event methods.
+    def on_current_program_scene_changed(data)
         ...
     end
-        @e_client.on :input_mute_state_changed do |data|
+    def on_input_mute_state_changed(data)
         ...
     end
-    end
+    ...
 end
 ```
 
@@ -97,12 +104,11 @@ For both request responses and event data you may inspect the available attribut
 example:
 
 ```ruby
-resp = @r_client.get_version
+resp = cl.get_version
 p resp.attrs
 
-@e_client.on :input_mute_state_changed do |data|
+def on_scene_created(data):
     p data.attrs
-end
 ```
 
 ### Errors

examples/events/main.rb

@@ -1,28 +1,19 @@
 require_relative "../../lib/obsws"
 require "yaml"
 
+
 class Main
   def initialize(**kwargs)
     @r_client = OBSWS::Requests::Client.new(**kwargs)
     @e_client = OBSWS::Events::Client.new(**kwargs)
-
+    @e_client.add_observer(self)
-    @e_client.on :current_program_scene_changed do |data|
-      puts "Switched to scene #{data.scene_name}"
-    end
-    @e_client.on :scene_created do |data|
-      puts "scene #{data.scene_name} has been created"
-    end
-    @e_client.on :input_mute_state_changed do |data|
-      puts "#{data.input_name} mute toggled"
-    end
-    @e_client.on :exit_started do
-      puts "OBS closing!"
-      @r_client.close
-      @e_client.close
-      @running = false
-    end
 
     puts infostring
+    @running = true
+  end
+
+  def run
+    sleep(0.1) while @running
   end
 
   def infostring
@@ -33,9 +24,23 @@ class Main
     ].join(" ")
   end
 
-  def run
+  def on_current_program_scene_changed(data)
-    @running = true
+    puts "Switched to scene #{data.scene_name}"
-    sleep(0.1) while @running
+  end
+
+  def on_scene_created(data)
+    puts "scene #{data.scene_name} has been created"
+  end
+
+  def on_input_mute_state_changed(data)
+    puts "#{data.input_name} mute toggled"
+  end
+
+  def on_exit_started
+    puts "OBS closing!"
+    @r_client.close
+    @e_client.close
+    @running = false
   end
 end
 

examples/levels/main.rb

@@ -13,13 +13,26 @@ class Main
   def initialize(**kwargs)
     subs = OBSWS::Events::SUBS::LOW_VOLUME | OBSWS::Events::SUBS::INPUTVOLUMEMETERS
     @e_client = OBSWS::Events::Client.new(subs:, **kwargs)
+    @e_client.register(
+      [
+        method(:on_input_mute_state_changed),
+        method(:on_input_volume_meters)
+      ]
+    )
+  end
 
-    @e_client.on :input_mute_state_changed do |data|
+  def run
+    puts "press <Enter> to quit"
+    loop { break if gets.chomp.empty? }
+  end
+
+  def on_input_mute_state_changed(data)
     if data.input_name == DEVICE
       puts "#{DEVICE} mute toggled"
     end
   end
-    @e_client.on :input_volume_meters do |data|
+
+  def on_input_volume_meters(data)
     fget = ->(x) { (x > 0) ? (20 * Math.log(x, 10)).round(1) : -200.0 }
 
     data.inputs.each do |d|
@@ -32,12 +45,6 @@ class Main
   end
 end
 
-  def run
-    puts "press <Enter> to quit"
-    loop { break if gets.chomp.empty? }
-  end
-end
-
 def conn_from_yaml
   YAML.load_file("obs.yml", symbolize_names: true)[:connection]
 end

lib/obsws/event.rb

@@ -28,35 +28,43 @@ module OBSWS
       ALL = LOW_VOLUME | HIGH_VOLUME
     end
 
-    module EventDirector
+    module Callbacks
       include Util::String
 
       def observers
-        @observers ||= {}
+        @observers ||= []
       end
 
-      def on(event, method = nil, &block)
+      def add_observer(observer)
-        (observers[event] ||= []) << (block || method)
+        observer = [observer] unless observer.respond_to? :each
+        observer.each { |o| observers << o unless observers.include? o }
       end
 
-      def register(cbs)
+      def remove_observer(observer)
-        cbs = [cbs] unless cbs.respond_to? :each
+        observer = [observer] unless observer.respond_to? :each
-        cbs.each { |cb| on(cb.name[3..].to_sym, cb) }
+        observers.reject! { |o| observer.include? o }
       end
 
-      def deregister(cbs)
+      private def notify_observers(event, data)
-        cbs = [cbs] unless cbs.respond_to? :each
+        observers.each do |o|
-        cbs.each { |cb| observers[cb.name[3..].to_sym]&.reject! { |o| cbs.include? o } }
+          if o.is_a? Method
+            if o.name.to_s == "on_#{snakecase(event)}"
+              data.empty? ? o.call : o.call(data)
+            end
+          elsif o.respond_to? "on_#{snakecase(event)}"
+            data.empty? ? o.send("on_#{snakecase(event)}") : o.send("on_#{snakecase(event)}", data)
+          end
+        end
       end
 
-      def fire(event, data)
+      alias_method :callbacks, :observers
-        observers[snakecase(event).to_sym]&.each { |block| data.empty? ? block.call : block.call(data) }
+      alias_method :register, :add_observer
-      end
+      alias_method :deregister, :remove_observer
     end
 
     class Client
       include Logging
-      include EventDirector
+      include Callbacks
       include Mixin::TearDown
       include Mixin::OPCodes
 
@@ -79,7 +87,7 @@ module OBSWS
             logger.debug("received: #{data}")
             event = data[:eventType]
             data = data.fetch(:eventData, {})
-            fire(event, Mixin::Data.new(data, data.keys))
+            notify_observers(event, Mixin::Data.new(data, data.keys))
           end
         }
       end

lib/obsws/version.rb

@@ -7,11 +7,11 @@ module OBSWS
     end
 
     def minor
-      6
+      5
     end
 
     def patch
-      0
+      8
     end
 
     def to_a