add spinners for all commands (including interactive mode).

pass send_command(interpret=True) for commands that return long responses.
note, it strips the first `"` from cvar responses which causes CVAR_REGEX to fail.
This commit is contained in:
onyx-and-iris 2026-03-23 14:45:35 +00:00
parent 3a7cc3eacb
commit d0519bb8e9
11 changed files with 99 additions and 67 deletions

View File

@ -1,6 +1,6 @@
import clypi import clypi
from aioq3rcon import Client, IncorrectPasswordError from aioq3rcon import Client, IncorrectPasswordError
from clypi import Command, arg from clypi import Command, Spinner, arg
from typing_extensions import override from typing_extensions import override
from . import console from . import console
@ -72,30 +72,37 @@ class Q3rconCli(Command):
clypi.style('to quit.', fg='blue'), clypi.style('to quit.', fg='blue'),
) )
DEFAULT_TIMEOUT = 2
DEFAULT_FRAGMENT_READ_TIMEOUT = 0.25 DEFAULT_FRAGMENT_READ_TIMEOUT = 0.25
while command := input(clypi.style('cmd: ', fg='green')): while command := input(clypi.style('cmd: ', fg='green')):
if command.lower() == 'q': if command.lower() == 'q':
break break
fragment_read_timeout = None TIMEOUTS = {
if command in ( 'status': (2, 1, False),
'status', 'fast_restart': (3, 1, True),
'fast_restart', 'map_restart': (3, 1, True),
'map_restart', 'map': (3, 1, True),
'map', 'map_rotate': (3, 1, True),
'map_rotate', }
): timeout, fragment_read_timeout, interpret = TIMEOUTS.get(
fragment_read_timeout = 1 command.split()[0].lower(),
(DEFAULT_TIMEOUT, DEFAULT_FRAGMENT_READ_TIMEOUT, False),
)
async with Spinner(f"Sending command: '{command}'", suffix='...'):
async with Client( async with Client(
self.host, self.host,
self.port, self.port,
self.password, self.password,
timeout=timeout or DEFAULT_TIMEOUT,
fragment_read_timeout=fragment_read_timeout fragment_read_timeout=fragment_read_timeout
or DEFAULT_FRAGMENT_READ_TIMEOUT, or DEFAULT_FRAGMENT_READ_TIMEOUT,
) as client: ) as client:
try: try:
if response := await client.send_command(command): if response := await client.send_command(
command, interpret=interpret
):
console.out.print_response(response) console.out.print_response(response)
except TimeoutError: except TimeoutError:
console.err.print( console.err.print(

View File

@ -1,5 +1,5 @@
from aioq3rcon import Client from aioq3rcon import Client
from clypi import Command, arg from clypi import Command, Spinner, arg
from typing_extensions import override from typing_extensions import override
from q3rcon_cli import console from q3rcon_cli import console
@ -14,6 +14,8 @@ class Fastrestart(Command):
@override @override
async def run(self): async def run(self):
async with Spinner('Executing fast restart', suffix='...'):
async with Client(self.host, self.port, self.password) as client: async with Client(self.host, self.port, self.password) as client:
if response := await client.send_command('fast_restart'): response = await client.send_command('fast_restart', interpret=True)
console.out.print_response(response) console.out.print_response(response)

View File

@ -1,5 +1,5 @@
from aioq3rcon import Client from aioq3rcon import Client
from clypi import Command, Positional, Spinner, arg, cprint from clypi import Command, Positional, Spinner, arg
from typing_extensions import override from typing_extensions import override
from q3rcon_cli import console from q3rcon_cli import console
@ -24,16 +24,23 @@ class Gametype(Command):
@override @override
async def run(self): async def run(self):
if not self.new_gametype: if not self.new_gametype:
async with Spinner('Fetching current gametype', suffix='...'):
async with Client(self.host, self.port, self.password) as client: async with Client(self.host, self.port, self.password) as client:
if response := await client.send_command('g_gametype'): response = await client.send_command('g_gametype')
console.out.print_cvar(response) console.out.print_cvar(response)
return return
async with Spinner(f'Changing gametype to {self.new_gametype}', suffix='...'):
async with Client(self.host, self.port, self.password) as client: async with Client(self.host, self.port, self.password) as client:
await client.send_command(f'g_gametype {self.new_gametype}') await client.send_command(f'g_gametype {self.new_gametype}')
if self.force: if self.force:
async with Spinner('Forcing gametype change', suffix='...'): async with Spinner('Forcing gametype change', suffix='...'):
async with Client(self.host, self.port, self.password) as client:
client.timeout = 3
client.fragment_read_timeout = 1 client.fragment_read_timeout = 1
await client.send_command('map_restart') await client.send_command('map_restart')
cprint(f'Gametype changed successfully to {self.new_gametype}.', fg='green') console.out.print(
f'Gametype changed successfully to {self.new_gametype}.', style='green'
)

View File

@ -1,5 +1,5 @@
from aioq3rcon import Client from aioq3rcon import Client
from clypi import Command, Positional, arg, cprint from clypi import Command, Positional, Spinner, arg
from typing_extensions import override from typing_extensions import override
from q3rcon_cli import console from q3rcon_cli import console
@ -19,12 +19,14 @@ class Hostname(Command):
@override @override
async def run(self): async def run(self):
if not self.new_hostname: if not self.new_hostname:
async with Spinner('Fetching current hostname', suffix='...'):
async with Client(self.host, self.port, self.password) as client: async with Client(self.host, self.port, self.password) as client:
if response := await client.send_command('sv_hostname'): response = await client.send_command('sv_hostname')
console.out.print_cvar(response) console.out.print_cvar(response)
return return
async with Spinner(f'Changing hostname to {self.new_hostname}', suffix='...'):
async with Client(self.host, self.port, self.password) as client: async with Client(self.host, self.port, self.password) as client:
await client.send_command(f'sv_hostname {self.new_hostname}') await client.send_command(f'sv_hostname {self.new_hostname}')
cprint(f'Hostname changed to: {self.new_hostname}', fg='green') console.out.print(f'Hostname changed to: {self.new_hostname}', style='green')

View File

@ -1,5 +1,5 @@
from aioq3rcon import Client from aioq3rcon import Client
from clypi import Command, Positional, Spinner, arg, cprint from clypi import Command, Positional, Spinner, arg
from typing_extensions import override from typing_extensions import override
from q3rcon_cli import console from q3rcon_cli import console
@ -19,8 +19,9 @@ class Map(Command):
@override @override
async def run(self): async def run(self):
if not self.new_map: if not self.new_map:
async with Spinner('Getting current map', suffix='...'):
async with Client(self.host, self.port, self.password) as client: async with Client(self.host, self.port, self.password) as client:
if response := await client.send_command('mapname'): response = await client.send_command('mapname')
console.out.print_cvar(response) console.out.print_cvar(response)
return return
@ -30,4 +31,6 @@ class Map(Command):
) as client: ) as client:
await client.send_command(f'map mp_{self.new_map.removeprefix("mp_")}') await client.send_command(f'map mp_{self.new_map.removeprefix("mp_")}')
cprint(f'Map changed to {self.new_map.removeprefix("mp_")}', fg='green') console.out.print(
f'Map changed to {self.new_map.removeprefix("mp_")}', style='green'
)

View File

@ -1,5 +1,5 @@
from aioq3rcon import Client from aioq3rcon import Client
from clypi import Command, arg from clypi import Command, Spinner, arg
from typing_extensions import override from typing_extensions import override
from q3rcon_cli import console from q3rcon_cli import console
@ -14,6 +14,8 @@ class Mapname(Command):
@override @override
async def run(self): async def run(self):
async with Spinner('Getting map name...'):
async with Client(self.host, self.port, self.password) as client: async with Client(self.host, self.port, self.password) as client:
if response := await client.send_command('mapname'): response = await client.send_command('mapname')
console.out.print_cvar(response) console.out.print_cvar(response)

View File

@ -16,7 +16,8 @@ class Maprestart(Command):
async def run(self): async def run(self):
async with Spinner('Restarting map', suffix='...'): async with Spinner('Restarting map', suffix='...'):
async with Client( async with Client(
self.host, self.port, self.password, fragment_read_timeout=1 self.host, self.port, self.password, timeout=3, fragment_read_timeout=1
) as client: ) as client:
if response := await client.send_command('map_restart'): response = await client.send_command('map_restart', interpret=True)
console.out.print_response(response) console.out.print_response(response)

View File

@ -16,7 +16,12 @@ class Maprotate(Command):
async def run(self): async def run(self):
async with Spinner('Rotating map', suffix='...'): async with Spinner('Rotating map', suffix='...'):
async with Client( async with Client(
self.host, self.port, self.password, fragment_read_timeout=1 self.host,
self.port,
self.password,
timeout=3,
fragment_read_timeout=1,
) as client: ) as client:
if response := await client.send_command('map_rotate'): response = await client.send_command('map_rotate', interpret=True)
console.out.print_response(response) console.out.print_response(response)

View File

@ -1,5 +1,5 @@
from aioq3rcon import Client from aioq3rcon import Client
from clypi import Command, arg from clypi import Command, Spinner, arg
from typing_extensions import override from typing_extensions import override
from q3rcon_cli import console from q3rcon_cli import console
@ -14,6 +14,8 @@ class Plugins(Command):
@override @override
async def run(self): async def run(self):
async with Spinner('Fetching plugins...'):
async with Client(self.host, self.port, self.password) as client: async with Client(self.host, self.port, self.password) as client:
if response := await client.send_command('plugins'): response = await client.send_command('plugins')
console.out.print_response(response) console.out.print_response(response)

View File

@ -16,7 +16,8 @@ class Status(Command):
async def run(self): async def run(self):
async with Spinner('Fetching status', suffix='...'): async with Spinner('Fetching status', suffix='...'):
async with Client( async with Client(
self.host, self.port, self.password, fragment_read_timeout=0.5 self.host, self.port, self.password, fragment_read_timeout=1
) as client: ) as client:
if response := await client.send_command('status'): response = await client.send_command('status')
console.out.print_status(response) console.out.print_status(response)

View File

@ -72,7 +72,7 @@ class OutConsole(Console):
_names.append(self._remove_colour_codes(m.group('name'))) _names.append(self._remove_colour_codes(m.group('name')))
_ips.append(m.group('ip')) _ips.append(m.group('ip'))
elif m := OutConsole.STATUS_MAP_REGEX.match(line): elif m := OutConsole.STATUS_MAP_REGEX.match(line):
cprint(f'\nCurrent map: {m.group("mapname")}', fg=self.style) cprint(f'Current map: {m.group("mapname")}', fg=self.style)
if not _slots: if not _slots:
cprint('No players connected.', fg='red') cprint('No players connected.', fg='red')