remove success add/remove to observers logs

log failure add/remove to observers at debug level.

This is all part of normal program flow.
This commit is contained in:
2026-04-28 12:45:40 +01:00
parent 5aae5dcba6
commit 84990367bd

View File

@@ -7,7 +7,7 @@ class Subject:
def __init__(self): def __init__(self):
"""Adds support for observers and callbacks""" """Adds support for observers and callbacks"""
self._observers = list() self._observers = []
self.logger = logger.getChild(self.__class__.__name__) self.logger = logger.getChild(self.__class__.__name__)
@property @property
@@ -34,15 +34,13 @@ class Subject:
for o in iterator: for o in iterator:
if o not in self._observers: if o not in self._observers:
self._observers.append(o) self._observers.append(o)
self.logger.info(f'{o} added to event observers')
else: else:
self.logger.error(f'Failed to add {o} to event observers') self.logger.debug(f'Failed to add {o} to event observers')
except TypeError: except TypeError:
if observer not in self._observers: if observer not in self._observers:
self._observers.append(observer) self._observers.append(observer)
self.logger.info(f'{observer} added to event observers')
else: else:
self.logger.error(f'Failed to add {observer} to event observers') self.logger.debug(f'Failed to add {observer} to event observers')
register = add register = add
@@ -54,15 +52,13 @@ class Subject:
for o in iterator: for o in iterator:
try: try:
self._observers.remove(o) self._observers.remove(o)
self.logger.info(f'{o} removed from event observers')
except ValueError: except ValueError:
self.logger.error(f'Failed to remove {o} from event observers') self.logger.debug(f'Failed to remove {o} from event observers')
except TypeError: except TypeError:
try: try:
self._observers.remove(observer) self._observers.remove(observer)
self.logger.info(f'{observer} removed from event observers')
except ValueError: except ValueError:
self.logger.error(f'Failed to remove {observer} from event observers') self.logger.debug(f'Failed to remove {observer} from event observers')
deregister = remove deregister = remove