From 9d3f58f6f2b58990b135109c649bfbcb2fc78ea0 Mon Sep 17 00:00:00 2001
From: pblivingston <71585805+pblivingston@users.noreply.github.com>
Date: Sat, 13 Dec 2025 11:42:23 -0500
Subject: [PATCH] knob threshold, audibility

move threshold back to comp/gate/denoiser so audibility can be derived from StripKnob

pester tests for safety pass
---
 CHANGELOG.md  |  2 +-
 lib/strip.ps1 | 18 ++++--------------
 2 files changed, 5 insertions(+), 15 deletions(-)

diff --git a/CHANGELOG.md b/CHANGELOG.md
index 4d6a640..a862c7c 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -58,7 +58,7 @@ Strip Gainlayers are now FloatArrayMember objects, see README for details
 - Strip.Karaoke alias for Strip.K
 - Strip.EQGain1|EQGain2|EQGain3 with bass/low, mid/med, treble/high aliases, respectively
 - StripAudibility class with Strip.Audibility.Knob
-- StripKnob base class for banana/potato audibility knobs with `knob` and `threshold`
+- StripKnob base class for audibility knobs with `knob`
 - Strip.Denoiser.Threshold
 - Strip.VAIO
 - Strip.Pitch, StripPitch class
diff --git a/lib/strip.ps1 b/lib/strip.ps1
index 9893fc5..1ac1528 100644
--- a/lib/strip.ps1
+++ b/lib/strip.ps1
@@ -77,7 +77,6 @@ class PhysicalStrip : Strip {
 
 class StripKnob : IRemote {
     StripKnob ([int]$index, [Object]$remote) : base ($index, $remote) {
-        AddFloatMembers -PARAMS @('threshold')
     }
 
     hidden $_knob = $($this | Add-Member ScriptProperty 'knob' `
@@ -93,7 +92,7 @@ class StripKnob : IRemote {
 
 class StripComp : StripKnob {
     StripComp ([int]$index, [Object]$remote) : base ($index, $remote) {
-        AddFloatMembers -PARAMS @('gainin', 'ratio', 'attack', 'release', 'knee', 'gainout')
+        AddFloatMembers -PARAMS @('gainin', 'ratio', 'threshold', 'attack', 'release', 'knee', 'gainout')
         AddBoolMembers -PARAMS @('makeup')
     }
 
@@ -104,7 +103,7 @@ class StripComp : StripKnob {
 
 class StripGate : StripKnob {
     StripGate ([int]$index, [Object]$remote) : base ($index, $remote) {
-        AddFloatMembers -PARAMS @('damping', 'bpsidechain', 'attack', 'hold', 'release')
+        AddFloatMembers -PARAMS @('threshold', 'damping', 'bpsidechain', 'attack', 'hold', 'release')
     }
 
     [string] identifier () {
@@ -114,6 +113,7 @@ class StripGate : StripKnob {
 
 class StripDenoiser : StripKnob {
     StripDenoiser ([int]$index, [Object]$remote) : base ($index, $remote) {
+        AddFloatMembers -PARAMS @('threshold')
     }
 
     [string] identifier () {
@@ -136,23 +136,13 @@ class StripPitch : IRemote {
     }
 }
 
-class StripAudibility : IRemote {
+class StripAudibility : StripKnob {
     StripAudibility ([int]$index, [Object]$remote) : base ($index, $remote) {
     }
 
     [string] identifier () {
         return 'Strip[' + $this.index + '].Audibility'
     }
-
-    hidden $_knob = $($this | Add-Member ScriptProperty 'knob' `
-        {
-            [math]::Round($this.Getter(''), 2)
-        } `
-        {
-            param([single]$arg)
-            return $this.Setter('', $arg)
-        }
-    )
 }
 
 class StripEq : IOEq {