From 9e84d02707ca763535d969cc4023d572349ae4f7 Mon Sep 17 00:00:00 2001 From: onyx-and-iris Date: Fri, 18 Aug 2023 21:26:54 +0100 Subject: [PATCH] remove message method override fix expect, actual order in error tests --- lib/voicemeeter.rb | 6 +----- test/test_error.rb | 10 +++++----- 2 files changed, 6 insertions(+), 10 deletions(-) diff --git a/lib/voicemeeter.rb b/lib/voicemeeter.rb index 030b862..d929a00 100644 --- a/lib/voicemeeter.rb +++ b/lib/voicemeeter.rb @@ -48,11 +48,7 @@ module Voicemeeter def initialize(fn_name, code) @fn_name = fn_name @code = code - super(message) - end - - def message - "#{fn_name} returned #{code}" + super("#{fn_name} returned #{code}") end end end diff --git a/test/test_error.rb b/test/test_error.rb index 06561fb..335ca10 100644 --- a/test/test_error.rb +++ b/test/test_error.rb @@ -4,22 +4,22 @@ require "voicemeeter" class CAPIErrorTest < Minitest::Test def test_it_raises_a_capierror_on_unknown_parameter e = assert_raises(Voicemeeter::Errors::VMCAPIError) { Test.vm.set("Unknown.Parameter", 1) } - assert_equal(e.fn_name, "VBVMR_SetParameterFloat") - assert_equal(e.code, -3) + assert_equal("VBVMR_SetParameterFloat", e.fn_name) + assert_equal(-3, e.code) end end class InvalidKindTest < MiniTest::Test def test_it_raises_a_vmerror_on_invalid_kind e = assert_raises(Voicemeeter::Errors::VMError) { Voicemeeter::Remote.new("unknown_kind") } - assert_equal(e.message, "unknown Voicemeeter kind 'unknown_kind'") + assert_equal("unknown Voicemeeter kind 'unknown_kind'", e.message) end end class UnknownConfigTest < MiniTest::Test def test_it_raises_a_vmerror_on_unknown_config_name e = assert_raises(Voicemeeter::Errors::VMError) { Test.vm.apply_config(:unknown) } - assert_equal(e.message, "unknown config 'unknown'. known configs: #{Test.vm.configs.keys}") + assert_equal("unknown config 'unknown'. known configs: #{Test.vm.configs.keys}", e.message) end end @@ -31,6 +31,6 @@ class UnknownConfigKey < MiniTest::Test "vban-out-3" => {on: true, bit: 24} } e = assert_raises(KeyError) { Test.vm.apply(config) } - assert_equal(e.message, "invalid config key 'unknown-0'") + assert_equal("invalid config key 'unknown-0'", e.message) end end