From d3289dbb8048ba2ced86c7bed0a039770907152b Mon Sep 17 00:00:00 2001
From: onyx-and-iris <75868496+onyx-and-iris@users.noreply.github.com>
Date: Sat, 25 Jun 2022 16:22:16 +0100
Subject: [PATCH] entry point GetRemote added

director and builder types added, one for each kind.

separates construction from representation
---
 tests/helper_test.go       |   2 +-
 voicemeeter/remote.go      | 148 ++++++++++++++++++++++++++++---------
 voicemeeter/remote_test.go |   6 +-
 3 files changed, 119 insertions(+), 37 deletions(-)

diff --git a/tests/helper_test.go b/tests/helper_test.go
index 29bbddd..e98e4d6 100644
--- a/tests/helper_test.go
+++ b/tests/helper_test.go
@@ -8,7 +8,7 @@ import (
 )
 
 var (
-	vmRem = voicemeeter.NewRemote("banana")
+	vmRem = voicemeeter.GetRemote("banana")
 )
 
 func TestMain(m *testing.M) {
diff --git a/voicemeeter/remote.go b/voicemeeter/remote.go
index c21cca6..5d32026 100644
--- a/voicemeeter/remote.go
+++ b/voicemeeter/remote.go
@@ -41,9 +41,111 @@ func (r *remote) SendText(script string) {
 	setParametersMulti(script)
 }
 
-// NewRemote returns a remote type of a kind,
-// this is the interface entry point.
-func NewRemote(kindId string) *remote {
+type remoteBuilder interface {
+	setKind() remoteBuilder
+	makeStrip() remoteBuilder
+	makeBus() remoteBuilder
+	makeButton() remoteBuilder
+	makeCommand() remoteBuilder
+	makeVban() remoteBuilder
+	Get() *remote
+}
+
+type director struct {
+	builder remoteBuilder
+}
+
+func (d *director) SetBuilder(b remoteBuilder) {
+	d.builder = b
+}
+
+func (d *director) Construct() {
+	d.builder.setKind().makeStrip().makeBus().makeButton().makeCommand().makeVban()
+}
+
+func (d *director) Get() *remote {
+	return d.builder.Get()
+}
+
+type genericBuilder struct {
+	k *kind
+	r remote
+}
+
+func (b *genericBuilder) setKind() remoteBuilder {
+	b.r.kind = b.k
+	return b
+}
+
+func (b *genericBuilder) makeStrip() remoteBuilder {
+	fmt.Println("building strip")
+	_strip := make([]t_strip, b.k.numStrip())
+	for i := 0; i < b.k.numStrip(); i++ {
+		if i < b.k.physIn {
+			_strip[i] = newPhysicalStrip(i)
+		} else {
+			_strip[i] = newVirtualStrip(i)
+		}
+	}
+	b.r.Strip = _strip
+	return b
+}
+
+func (b *genericBuilder) makeBus() remoteBuilder {
+	fmt.Println("building bus")
+	_bus := make([]t_bus, b.k.numBus())
+	for i := 0; i < b.k.numBus(); i++ {
+		if i < b.k.physOut {
+			_bus[i] = newPhysicalBus(i)
+		} else {
+			_bus[i] = newVirtualBus(i)
+		}
+	}
+	b.r.Bus = _bus
+	return b
+}
+
+func (b *genericBuilder) makeButton() remoteBuilder {
+	fmt.Println("building button")
+	_button := make([]button, 80)
+	for i := 0; i < 80; i++ {
+		_button[i] = newButton(i)
+	}
+	b.r.Button = _button
+	return b
+}
+
+func (b *genericBuilder) makeCommand() remoteBuilder {
+	fmt.Println("building command")
+	_command := newCommand()
+	b.r.Command = _command
+	return b
+}
+
+func (b *genericBuilder) makeVban() remoteBuilder {
+	fmt.Println("building vban")
+	_vban := newVban(b.k)
+	b.r.Vban = _vban
+	return b
+}
+
+func (b *genericBuilder) Get() *remote {
+	return &b.r
+}
+
+type basicBuilder struct {
+	genericBuilder
+}
+
+type bananaBuilder struct {
+	genericBuilder
+}
+
+type potatoBuilder struct {
+	genericBuilder
+}
+
+func GetRemote(kindId string) *remote {
 	_kind, ok := kindMap[kindId]
 	if !ok {
 		err := fmt.Errorf("unknown Voicemeeter kind '%s'", kindId)
@@ -51,35 +153,15 @@ func NewRemote(kindId string) *remote {
 		os.Exit(1)
 	}
 
-	_strip := make([]t_strip, _kind.numStrip())
-	for i := 0; i < _kind.numStrip(); i++ {
-		if i < _kind.physIn {
-			_strip[i] = newPhysicalStrip(i)
-		} else {
-			_strip[i] = newVirtualStrip(i)
-		}
-	}
-	_bus := make([]t_bus, _kind.numBus())
-	for i := 0; i < _kind.numBus(); i++ {
-		if i < _kind.physOut {
-			_bus[i] = newPhysicalBus(i)
-		} else {
-			_bus[i] = newVirtualBus(i)
-		}
-	}
-	_button := make([]button, 80)
-	for i := 0; i < 80; i++ {
-		_button[i] = newButton(i)
-	}
-	_command := newCommand()
-	_vban := newVban(_kind)
-
-	return &remote{
-		kind:    _kind,
-		Strip:   _strip,
-		Bus:     _bus,
-		Button:  _button,
-		Command: _command,
-		Vban:    _vban,
+	director := director{}
+	switch _kind.name {
+	case "basic":
+		director.SetBuilder(&basicBuilder{genericBuilder{_kind, remote{}}})
+	case "banana":
+		director.SetBuilder(&bananaBuilder{genericBuilder{_kind, remote{}}})
+	case "potato":
+		director.SetBuilder(&potatoBuilder{genericBuilder{_kind, remote{}}})
 	}
+	director.Construct()
+	return director.Get()
 }
diff --git a/voicemeeter/remote_test.go b/voicemeeter/remote_test.go
index 211005e..fddd0b5 100644
--- a/voicemeeter/remote_test.go
+++ b/voicemeeter/remote_test.go
@@ -8,7 +8,7 @@ import (
 
 func TestGetBasicRemote(t *testing.T) {
 	//t.Skip("skipping test")
-	__rem := NewRemote("basic")
+	__rem := GetRemote("basic")
 	t.Run("Should return a remote basic type", func(t *testing.T) {
 		assert.NotNil(t, __rem)
 	})
@@ -25,7 +25,7 @@ func TestGetBasicRemote(t *testing.T) {
 
 func TestGetBananaRemote(t *testing.T) {
 	//t.Skip("skipping test")
-	__rem := NewRemote("banana")
+	__rem := GetRemote("banana")
 	t.Run("Should return a remote banana type", func(t *testing.T) {
 		assert.NotNil(t, __rem)
 	})
@@ -42,7 +42,7 @@ func TestGetBananaRemote(t *testing.T) {
 
 func TestGetPotatoRemote(t *testing.T) {
 	//t.Skip("skipping test")
-	__rem := NewRemote("potato")
+	__rem := GetRemote("potato")
 	t.Run("Should return a remote basic type", func(t *testing.T) {
 		assert.NotNil(t, __rem)
 	})