knob threshold, audibility

move threshold back to comp/gate/denoiser so audibility can be derived from StripKnob

pester tests for safety pass
This commit is contained in:
pblivingston 2025-12-13 11:42:23 -05:00
parent ea6192ba5f
commit 9d3f58f6f2
2 changed files with 5 additions and 15 deletions

View File

@ -58,7 +58,7 @@ Strip Gainlayers are now FloatArrayMember objects, see README for details
- Strip.Karaoke alias for Strip.K - Strip.Karaoke alias for Strip.K
- Strip.EQGain1|EQGain2|EQGain3 with bass/low, mid/med, treble/high aliases, respectively - Strip.EQGain1|EQGain2|EQGain3 with bass/low, mid/med, treble/high aliases, respectively
- StripAudibility class with Strip.Audibility.Knob - StripAudibility class with Strip.Audibility.Knob
- StripKnob base class for banana/potato audibility knobs with `knob` and `threshold` - StripKnob base class for audibility knobs with `knob`
- Strip.Denoiser.Threshold - Strip.Denoiser.Threshold
- Strip.VAIO - Strip.VAIO
- Strip.Pitch, StripPitch class - Strip.Pitch, StripPitch class

View File

@ -77,7 +77,6 @@ class PhysicalStrip : Strip {
class StripKnob : IRemote { class StripKnob : IRemote {
StripKnob ([int]$index, [Object]$remote) : base ($index, $remote) { StripKnob ([int]$index, [Object]$remote) : base ($index, $remote) {
AddFloatMembers -PARAMS @('threshold')
} }
hidden $_knob = $($this | Add-Member ScriptProperty 'knob' ` hidden $_knob = $($this | Add-Member ScriptProperty 'knob' `
@ -93,7 +92,7 @@ class StripKnob : IRemote {
class StripComp : StripKnob { class StripComp : StripKnob {
StripComp ([int]$index, [Object]$remote) : base ($index, $remote) { StripComp ([int]$index, [Object]$remote) : base ($index, $remote) {
AddFloatMembers -PARAMS @('gainin', 'ratio', 'attack', 'release', 'knee', 'gainout') AddFloatMembers -PARAMS @('gainin', 'ratio', 'threshold', 'attack', 'release', 'knee', 'gainout')
AddBoolMembers -PARAMS @('makeup') AddBoolMembers -PARAMS @('makeup')
} }
@ -104,7 +103,7 @@ class StripComp : StripKnob {
class StripGate : StripKnob { class StripGate : StripKnob {
StripGate ([int]$index, [Object]$remote) : base ($index, $remote) { StripGate ([int]$index, [Object]$remote) : base ($index, $remote) {
AddFloatMembers -PARAMS @('damping', 'bpsidechain', 'attack', 'hold', 'release') AddFloatMembers -PARAMS @('threshold', 'damping', 'bpsidechain', 'attack', 'hold', 'release')
} }
[string] identifier () { [string] identifier () {
@ -114,6 +113,7 @@ class StripGate : StripKnob {
class StripDenoiser : StripKnob { class StripDenoiser : StripKnob {
StripDenoiser ([int]$index, [Object]$remote) : base ($index, $remote) { StripDenoiser ([int]$index, [Object]$remote) : base ($index, $remote) {
AddFloatMembers -PARAMS @('threshold')
} }
[string] identifier () { [string] identifier () {
@ -136,23 +136,13 @@ class StripPitch : IRemote {
} }
} }
class StripAudibility : IRemote { class StripAudibility : StripKnob {
StripAudibility ([int]$index, [Object]$remote) : base ($index, $remote) { StripAudibility ([int]$index, [Object]$remote) : base ($index, $remote) {
} }
[string] identifier () { [string] identifier () {
return 'Strip[' + $this.index + '].Audibility' return 'Strip[' + $this.index + '].Audibility'
} }
hidden $_knob = $($this | Add-Member ScriptProperty 'knob' `
{
[math]::Round($this.Getter(''), 2)
} `
{
param([single]$arg)
return $this.Setter('', $arg)
}
)
} }
class StripEq : IOEq { class StripEq : IOEq {